[Bug] GoldenDict keep adding "&" in group name

[cuongha0701]

Describe the bug GoldenDict keep adding "&" character in group name

To Reproduce Steps to reproduce the behavior:

1. Go to Edit
2. Click on Dictionaries
3. Click on Groups
4. Click on OK | Apply button
5. See error

Screenshots

OS and software versions KDE Plasma 6.0.4 Goldendict-ng 24.02.16.e78aff27 at 2024-04-24T04:58:00Z Qt 6.7.0 GCC 13.2.1 20230801 arch linux 6.8.7-arch1-2 x86_64-little_endian-lp64 Flags: MAKE_ZIM_SUPPORT USE_ICONV MAKE_CHINESE_CONVERSION_SUPPORT

[shenlebantongying]

Yes, I reproduced on KDE6 + Qt6.7. This is a KDE only bug.

The & has a special meaning https://doc.qt.io/qt-6/qshortcut.html#details for mnemonic shortcuts.

By holding Alt, the first group tab is highlighted, while the others are not, Alt+Z will jump to the first tab.

The first tab will trigger this bug.

KDE automatically modifies the text string to include a & for mnemonic shortcuts, and we do & escaping, which makes the modification persist.

Escaping on GD's side https://github.com/goldendict/goldendict/commit/ed2876d7b2ab634af5613de136dcfd2340c80a7c

Previous similar bugs:

https://github.com/goldendict/goldendict/issues/847 https://github.com/goldendict/goldendict/issues/1031

[xiaoyifang]

https://stackoverflow.com/questions/32688153/how-to-disable-automatic-mnemonics-in-a-qt-application-on-kde

[xiaoyifang]

A possible solution: 1, when add new group , escape the & character. 2, when display ,do not escape the & character.

[shenlebantongying]

1, when add new group , escape the & character.

This is exactly what GD is doing 😅.

https://github.com/goldendict/goldendict/commit/ed2876d7b2ab634af5613de136dcfd2340c80a7c#diff-ca4a0baa33b84a02d00fc0857a37dda1d26e53c3f0f99f8f92fc7d9bb706858bR284-R286

I think the root fix is either

• Fix KDE
• Stop storing program states/variables in UI widgets, refactor the related code properly into something like MVC

[xiaoyifang]

Gd-ng has done the following two things: 1, when add new group , escape the & character. 2, when display ,escape the & character. (DO NOT NEEDED)

only 1 is needed.