xiaoyifang / goldendict-ng

The Next Generation GoldenDict
https://xiaoyifang.github.io/goldendict-ng/
Other
1.68k stars 93 forks source link

[Feature] Improve changelog generation #1684

Closed xiaoyifang closed 1 week ago

xiaoyifang commented 3 months ago

gd-ng use mikepenz/release-changelog-builder-action@v3 to generate the changelog, it has generated some unintended content.

image

maybe related with some wrong configuration .

need a better way to generate this .

KonstantinDjairo commented 3 months ago

isn't there a way to use regex to get rid of unwanted info?

xiaoyifang commented 3 months ago

the changelog based on the result of git diff commit1..commit2 the result of git diff seems give out different results when the default merged branch is different.

shenlebantongying commented 1 week ago

With https://github.com/xiaoyifang/goldendict-ng/pull/1836, we can just manually trigger the build from the staged branch instead of merging it to dev so that there will be no "merge staged to dev" commits anymore.

I guess this can be counted as fixed. (For release build, let's consider it before next release. Or we simply don't consider at all, because it don't happen frequently, manually editing the note is just fine 😅.)