search

xiaoyifang / goldendict-ng

The Next Generation GoldenDict
https://xiaoyifang.github.io/goldendict-ng/
Other
1.71k stars 95 forks source link

clean: add `override` to satisfy clang's `Winconsistent-missing-override` #1903

Closed shenlebantongying closed 2 weeks ago

shenlebantongying commented 2 weeks ago

It seems newer version of clang has this warning enabled by default and the build log full of this thing.

https://github.com/xiaoyifang/goldendict-ng/actions/runs/11622770897/job/32368748936

clang-tidy doesn't appear to be able to catch all cases https://github.com/xiaoyifang/goldendict-ng/pull/293

sonarcloud[bot] commented 2 weeks ago

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint