clean: simplify macOS hotkey mapping code

shenlebantongying commented 1 week ago

Let's merge this in another day,

Chop related code to half.

This region of code looked scary because the first line assumes everyone uses English keyboard.

TISInputSourceRef inputSourceRef = TISCopyInputSourceForLanguage(CFSTR("en"));

So, the next line patches it by copying current input source -> TISCopyCurrentKeyboardInputSource

But japanese keyboard is slightly different, so it got patched again with TISCopyCurrentKeyboardLayoutInputSource

Just uses the last one TISCopyCurrentKeyboardLayoutInputSource, all code are no longer needed.

Also change mappping to a vector instead of calloc.

shenlebantongying commented 1 week ago

Don't think this will bring any regression, because the simplified code user the thing that handles https://github.com/goldendict/goldendict/pull/1419

Also tested other situations -> chinese input method & English

sonarcloud[bot] commented 1 week ago

Quality Gate passed