search

xiaoyifang / goldendict-ng

The Next Generation GoldenDict
https://xiaoyifang.github.io/goldendict-ng/
Other
1.71k stars 95 forks source link

clean: remove redundant gd::toWString #1946

Closed shenlebantongying closed 1 week ago

shenlebantongying commented 1 week ago

The reason there is such function was because the Windows version of gd::wstring is whatever we don't care anymore.

https://github.com/timonwong/goldendict/commit/babde3d53d21f8ba2a13c41d0cf2f391e6839094#diff-426cee2bb29733a476f42c3ba97c2ebc90647d51f30d6feb74b5fee3d15976b4R4-R32

Let's just use the real thing.

sonarcloud[bot] commented 1 week ago

Quality Gate Failed Quality Gate failed

Failed conditions
6.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud