xiaoyifang / goldendict-ng

The Next Generation GoldenDict
https://xiaoyifang.github.io/goldendict-ng/
Other
1.72k stars 95 forks source link

refactor: move most of the Windows specific code out of `hotkeywrapper.cc` #1952

Closed shenlebantongying closed 1 week ago

shenlebantongying commented 1 week ago

Plus small adjustments that have no semantic changes.


Why?

Google #ifdef HellπŸ˜…

It is pretty hard to understand these code with code from 3 platforms mangling together.

shenlebantongying commented 1 week ago

I checked out the history of win related code in the original GD.

I don't see anything useful except

In the existing code, What You See Is What You Get (WYSIWYG)πŸ˜…

sonarcloud[bot] commented 1 week ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud