fix macOS libzim <> icu4c again and add verification to make mismatch a fatal error

xiaoyifang / goldendict-ng

The Next Generation GoldenDict

https://xiaoyifang.github.io/goldendict-ng/

Other

1.71k stars 95 forks source link

Closed shenlebantongying closed 6 days ago

shenlebantongying commented 6 days ago

Homebrew is in a long migration of icu 75->76.

Now, libzim depends on icu4c@76.

Add rudimentary code to verify it.

(Random:

I don't like any of these, but let's work with this for now.

I tried to use vcpkg on macOS like our Windows build too, but it doesn't work starting from here -> https://github.com/microsoft/vcpkg/pull/39600)

sonarcloud[bot] commented 6 days ago

xiaoyifang commented 6 days ago

is this a libzim dependence issue? If yes, can report this to libzim project.

xiaoyifang commented 5 days ago

xiaoyifang commented 5 days ago

Windows build too, but it doesn't work starting from here -> microsoft/vcpkg#39600)

the link is opencc?

shenlebantongying commented 5 days ago

FindICU finds the icu provided by Apple's SDK (? or system itself)

We need the one from homebrew which libzim linked with.

xiaoyifang commented 5 days ago

Is this some libzim link problem?

xiaoyifang commented 4 days ago

shenlebantongying commented 4 days ago