search

xiaoyifang / goldendict-ng

The Next Generation GoldenDict
https://xiaoyifang.github.io/goldendict-ng/
Other
1.71k stars 95 forks source link

refactor: move "internalpayerbackend", which is not a backend, to src/audio #1956

Closed shenlebantongying closed 6 days ago

shenlebantongying commented 6 days ago

I think this is a good time to switch default to Qt multimedia.

Then I find this weird warning. Why the hell changing the default require changing more code?

https://github.com/xiaoyifang/goldendict-ng/blob/c7d0feb2e8d237f21365da2a7a1e56f0a6e7e78d/src/audio/audioplayerfactory.cc#L52-L54

Then I found this unusual thing in the middle of config.

It is called as "backend" and can be acts as "backend", but it doesn't work as a "backend" (because it invokes other backends).

Anyway, let's move it out from the big config.cc.

git blame is not useful here. The commit message is just useless blurps https://github.com/xiaoyifang/goldendict-ng/commit/9aa3c44d4eddea4ae5197fb974173e65f80e97a3

sonarcloud[bot] commented 6 days ago

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud