action: update brew before running macOS workflows

xiaoyifang / goldendict-ng

The Next Generation GoldenDict

https://xiaoyifang.github.io/goldendict-ng/

Other

1.72k stars 95 forks source link

Closed shenlebantongying closed 1 week ago

shenlebantongying commented 1 week ago

Whatever in the GitHub's runner image is outdated compared to whatever in the remote server.

sonarcloud[bot] commented 1 week ago

xiaoyifang commented 1 week ago

from the size of the final macos package, it seems the icu-data may be still not got packaged.https://github.com/xiaoyifang/goldendict-ng/releases/tag/v24.11.0-alpha.652da8e1

shenlebantongying commented 1 week ago

libicui18n.dylib and libicuuc.dylib are both in the dmg files.

libzim only needs icu-i18n (and indirectly icu-uc). I don't think it requires icu-data.

The FindICU macro provided by CMake is not what we needs.

There are Apple's ICU <-> homebrew's ICU. The FindICU from CMake will find the System's ICU and the libzim built by homebrew requires homebrew's ICU.

shenlebantongying commented 1 week ago

Ok, it appears things changed, now it also requires icudata

xiaoyifang commented 1 week ago

icuuc->icudata