feat: Windows, use Fusion only when dark mode applied

xiaoyifang / goldendict-ng

The Next Generation GoldenDict

https://xiaoyifang.github.io/goldendict-ng/

Other

1.72k stars 95 forks source link

Closed atauzki closed 6 days ago

atauzki commented 6 days ago

It's better than just keep Fusion style used.

pcsx2 switches their themes between fusion and windows, we can do it too.

Bandicam seems dont capture my settings windows.

shenlebantongying commented 6 days ago

I don't remember the details, right after Qt6.7.0 release. Switching between WindowsModern/Vista/Fusion will cause various problems.

They looks like fixed. This change looks fine.

I think for Qt6.8+, we can switch to Qt's dark theme, which is available in Windows Modern & Fusion (& & Vista?) theme.

However, we are hard stuck in Qt6.7.2 by this https://github.com/xiaoyifang/goldendict-ng/issues/1738 right now.

atauzki commented 6 days ago

I don't like modern theme very much, don't they have UI designer?

and they breaks yahei font in 6.8…takes more ugly simsum back again, esp in hidpi screen .

sonarcloud[bot] commented 6 days ago

atauzki commented 6 days ago

I think for Qt6.8+, we can switch to Qt's dark theme, which is available in Windows Modern & Fusion (& & Vista?) theme.

Modern yes, Fusion yes, Vista no. Tested by latest pcsx2(built by qt6.8.0).