search

xiaoyifang / goldendict-ng

The Next Generation GoldenDict
https://xiaoyifang.github.io/goldendict-ng/
Other
1.71k stars 95 forks source link

clean: delete useless fopen style mode char* API from File::Index #1968

Closed shenlebantongying closed 2 days ago

shenlebantongying commented 2 days ago

They are useless ever since the original GD.

Stop parsing this 2 char str for nothing.

Depends on https://github.com/xiaoyifang/goldendict-ng/pull/1965

sonarcloud[bot] commented 2 days ago

Quality Gate Failed Quality Gate failed

Failed conditions
3.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

xiaoyifang commented 2 days ago

'rb' equals ReadOnly + Binary , from the code ,it should be used

shenlebantongying commented 2 days ago

There is no flag for binary in Qt.

The original code merely set it then cancel the Text flag 😅

xiaoyifang commented 2 days ago

yes, in addition.
image