search

xiaoyifang / goldendict-ng

The Next Generation GoldenDict
https://xiaoyifang.github.io/goldendict-ng/
Other
1.71k stars 95 forks source link

clean: remove duplicated `getName` overrides #1972

Closed shenlebantongying closed 2 days ago

shenlebantongying commented 2 days ago

dictionaryName has protected visibility.

https://github.com/xiaoyifang/goldendict-ng/blob/9c46e5c317b894c3aab9dfb6efd2dd38e94352c7/src/dict/dictionary.hh#L318

Classes that don't use it just carries an unused std::string.

sonarcloud[bot] commented 2 days ago

Quality Gate Passed Quality Gate passed

Issues
8 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud