The binary's name should be changed

xiaoyifang / goldendict-ng

The Next Generation GoldenDict

https://xiaoyifang.github.io/goldendict-ng/

Other

1.61k stars 87 forks source link

Closed data-man closed 1 year ago

data-man commented 1 year ago

To avoid conflict with the original GD.

E.g. to goldendict-ng.

shenlebantongying commented 1 year ago

Changing the binary name /usr/bin/goldendict on linux will break someone's scripts.

It should not be changed on linux, but the display name of the desktop file can be changed.

data-man commented 1 year ago

It should not be changed on linux

Many Linux distros has goldendict package and will conflict with goldendict-ng.

Thus, an user can install both to compare the features. :)

shenlebantongying commented 1 year ago

Many Linux distros has goldendict package

This is no longer the reality, only a few distros have it :)

https://repology.org/project/goldendict/versions (a few of them is this repo but without name change).

debian has both goldendict & goldendict-webengine, and it works ok.

Also, longer name need more types when using command line.

I might be wrong, but I feel renaming the executable is a breaking change for Linux users if they already use this repo :)

data-man commented 1 year ago

debian has both goldendict & goldendict-webengine, and it works ok.

No.

$ sudo apt install goldendict goldendict-webengine

The following packages have unmet dependencies: goldendict-webengine : Breaks: goldendict

is a breaking change for Linux users

That's the way! :)

xiaoyifang commented 1 year ago

Maybe need some more time to think a better idea.

xiaoyifang commented 1 year ago

install with a different prefix

shenlebantongying commented 1 year ago

The binary name is not the only thing that conflict.

There are also icons and other resources.

If we don't change /usr/share/pixmaps/goldendict.png, the icons provided by themes can be directly used.