search

xibodevelopment / backupwordpress

Simple automated backups of your WordPress powered website.
http://wordpress.org/extend/plugins/backupwordpress/
327 stars 74 forks source link

Ensure uninstall.php is PHP 5.2 compatible #1045

Open katmoody opened 8 years ago

katmoody commented 8 years ago

So a user wasn't able to use the plugin after I getting a message saying they needed php 5.3.2 or later and would not install, and they went to delete it, getting this error:

Parse error: syntax error, unexpected T_STRING in /home/lollipop/public_html/wp-content/plugins/backupwordpress/uninstall.php on line 16

Not positive if it has been addressed or not but wanted to report it just in case. :D

Intercom ticket: https://app.intercom.io/a/apps/7f1l4qyq/inbox/all/conversations/4408280273

willmot commented 8 years ago

Ah, we should make uninstall.php PHP 5.2 compatible.

pdewouters commented 8 years ago

I think that's an old version though

willmot commented 8 years ago

@pdewouters what makes you say that?

pdewouters commented 8 years ago

line 16 is a blank line in the current version

but yes, this line will not work https://github.com/humanmade/backupwordpress/blob/master/uninstall.php#L15

I thought we'd fixed that, but I'm confusing with https://github.com/humanmade/backupwordpress/issues/1021

roborourke commented 7 years ago

Used https://github.com/wimg/PHPCompatibility to make sure there was nothing else.