search

xibodevelopment / backupwordpress

Simple automated backups of your WordPress powered website.
http://wordpress.org/extend/plugins/backupwordpress/
328 stars 74 forks source link

Files excluded when name matches excluded folder #1094

Open katmoody opened 7 years ago

katmoody commented 7 years ago

There was first one file and now multiple files that are being excluded from this person’s backup even though they never set exclusions. They are (I think) on to using another plugin now, but I want to at least have an idea of what might have gone on here in case it comes up again.

Intercom Ticket: https://app.intercom.io/a/apps/7f1l4qyq/inbox/all/conversations/5220924531 Original post in WP Forum: https://wordpress.org/support/topic/random_bytes_dev_urandomphp-didnt-back-up

I tried to reproduce this on my test site with no success. 😦

willmot commented 7 years ago

Looking at that screenshot, there's an exclude rule for dev which would match random_bytes_dev_urandom.php.

That's definitely not ideal and clearly not what the user would expect, we have https://github.com/humanmade/backupwordpress/issues/777 covering that

dashaluna commented 7 years ago

@willmot @katmoody admin question: what do we do with closed issues like this? Do we tag it with something? Do we remove it from milestone or move to Complete Issues in Project view?

willmot commented 7 years ago

I'd either move them to complete or have another column called wontfix

katmoody commented 7 years ago

Reopening this as I've kept in touch with the person who originally reported it to me and I was finally able to replicate it - even when I use the full absolute path to the /dev/ folder it still excludes other files with the dev within it. I've still got this set up on my test site if anyone wants to check it out. @willmot - just updating based on getting it replicated on my test server

katmoody commented 6 years ago

So I changed the title to better reflect this and have had a couple other tickets come in with matching issues.

Basically if a directory is excluded (ie. 'dev') it will also match that name in any filenames. We should be able to exclude by name or by filepath so we can avoid this in the future. Unsure offhand what that would take to change, but editing so we can work it up and decide. :D

Just want to also note that the excludes when done via the admin page doesn't seem to happen as expected either, since it will also exclude the filename instead of the filepath.