xibosignage / xibo-dotnetclient

Xibo for Windows .NET Player
GNU Affero General Public License v3.0
63 stars 91 forks source link

XMR: consuming multiple sockets #247

Closed dasgarner closed 2 years ago

dasgarner commented 2 years ago

If a socket connection is made but we never receive a heartbeat the player will try to restart the XMR process due to inactivity. It looks like restarting doesn't close the active socket and therefore we get a build up of open sockets at the XMR end.

Perhaps we ought to call dispose here: https://github.com/xibosignage/xibo-dotnetclient/blob/develop/Action/XmrSubscriber.cs#L286

Maybe we ought to consider assuming a successful first connection too? https://github.com/xibosignage/xibo-dotnetclient/blob/develop/Action/XmrSubscriber.cs#L45