Unwanted alert window: Unexpected use of reserved word 'let' in strict mode

xibosignage / xibo-linux

Xibo for Linux - Digital Signage Player

https://xibo.org.uk/xibo-for-linux

GNU Affero General Public License v3.0

76 stars 54 forks source link

Unwanted alert window: Unexpected use of reserved word 'let' in strict mode #245

Open Commifreak opened 3 years ago

Commifreak commented 3 years ago

Describe the bug One region, one HTML View: The linux player embedded HTML viewer has problems with Javascript's let keyword.

To Reproduce Embed HTML page with let Javascript? I included Check_MK dashboard to let this happen.

Expected behavior No JS error

Logs not applicable

Screenshots grafik

Environment (please complete the following information):

Linux Disto: Ubuntu 20.04
Linux Desktop Environment: GNOME
How the player was launched: snap
Player Version: 1.8-R6

dasgarner commented 3 years ago

The Linux player browser engine does not support ES6 syntax which is why you're getting this error (that same page would not work in many older Android devices, IE or Safari 8, either).

The only recourse in this case is to update the source web page for ES5.

We should not show the alert dialog though! So I will re-purpose this bug report for that.

Commifreak commented 3 years ago

Maybe it would be better to upgrade the browser engine to support ES6?

dasgarner commented 3 years ago

We have an open PR for this, which outlines the problems we're facing doing that: https://github.com/xibosignage/xibo-linux/pull/179

Currently we're faced with building WebKitGTK entirely from source, which really isn't optimal.

If you would like to take a look at it and update the PR then that would be much appreciated.

Commifreak commented 3 years ago

Thats something I can't help with. I can program in PHP - thats all :)