search

xibosignage / xibo

Xibo Digital Signage
https://xibosignage.com
GNU Affero General Public License v3.0
568 stars 164 forks source link

3.0.0 docker installation: mysql container fails to start #2542

Closed sergey-selivanov closed 3 years ago

sergey-selivanov commented 3 years ago

In both xibo-docker.zip and xibo-docker.tar.gz files provided under 3.0.0 release, there are improper double quotes in docker-compose.yml around a mysqld command, like \\ and // instead of straight ones lke || . This prevents mysql container to start, with cycling errors.

diff docker-compose.yml docker-compose.yml.orig
12c12
<         command: mysqld --sql_mode="ONLY_FULL_GROUP_BY,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION"
---
>         command: mysqld --sql_mode=“ONLY_FULL_GROUP_BY,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION”
dasgarner commented 3 years ago

Thank you very much, this was an attempt to fix another problem we had with upgrading. I've rolled back the change and will republish the release.

Your report is much appreciated!

sergey-selivanov commented 3 years ago

Glad to help, thanks!