search

xibosignage / xibo

Xibo Digital Signage
https://xibosignage.com
GNU Affero General Public License v3.0
566 stars 165 forks source link

Android Player Software Incorrectly Labeled #3359

Open otdi-gh opened 6 months ago

otdi-gh commented 6 months ago

Xibo CMS 3.3.9 (Docker)

Issue: When filetype .apk is added to the Generic File module allow list, Android player software does not correctly upload to the system. It will Abort on first upload attempt, then Fail subsequent attempts noting that the file is already uploaded. Player software is then mislabeled as type 'Generic File' in the database and does not show up correctly as an assignable Player Software.

image

image

Steps to reproduce: Modify the 'Generic File' module to include '.apk' as a valid file extension. Upload a new Player Software to the system.

Workaround: Remove '.apk' as a valid file extension before uploading player software files to the system.

Other considerations: Perhaps this also happens with MSI files and other player software extensions for other platforms, but we did not test that as 99% of our players are Android.

dasgarner commented 6 months ago

Thank you for the bug report - I suppose the only solution here would be to disallow setting apk as a valid extension for a generic file.

In v4 we have handled player software separately to the module system, so I believe this will no longer be an issue.