xibosignage / xibo

Xibo Digital Signage
https://xibosignage.com
GNU Affero General Public License v3.0
572 stars 164 forks source link

DataSet: trying to import without any columns logs an unhelpful error #3458

Closed dasgarner closed 1 month ago

dasgarner commented 2 months ago

The error we log currently is shown below:

[2024-07-17 11:33:19] CONSOLE.DEBUG: INSERT INTO `dataset_1` (``) VALUES () [] {"method":"GET","route":"/6","uid":"a582122"}
[2024-07-17 11:33:19] CONSOLE.ERROR: run: SQLSTATE[42S22]: Column not found: 1054 Unknown column '' in 'field list' Exception Type

We could improve this message to better indicate what the problem is, and perhaps even abort the import much sooner if there are no columns configured.

Could we also put a message on the edit form to remind the user to go and configure their columns if there are no columns marked as "Remote" or none at all?