xibyte / jsketcher

Parametric 2D and 3D modeler written in pure javascript
http://web-cad.org
Other
1.49k stars 279 forks source link

Fix some problems of svg exporting #185

Closed xia0hj closed 1 year ago

xia0hj commented 2 years ago

Hi,

I found some problems when using svg exporting in 2D Sketcher:

  1. The exported svg is fliped, becase in svg the positive y direction is top-to-bottom. I fixed it simply by flipping svg vertically.
  2. Some sketcher objects show incompletely dut to wrong width and height, i correct the viewbox args.
  3. Add supports for exporting Ellipse, EllipticalArc and BezierCurve.
mmiscool commented 1 year ago

This PR should be merged to the main branch in about 2 weeks when we will be merging over all the dev branch stuff. We have not forgotten about this and appreciate the PR.