search

xicodomingues / francinette

An easy to use testing framework for the 42 projects
MIT License
463 stars 44 forks source link

libft: get error in command francinette and OK in command paco, ft_putstr_fd and ft_putendl_fd #67

Open EvertonVaz opened 1 year ago

EvertonVaz commented 1 year ago

When I run the command francinette to test the entire libft, I get an error in two functions

Summary:

Failed tests: putendl_fd, putstr_fd

Errors found:

For ft_putstr_fd, in /nfs/homes/usr/francinette/tests/libft/fsoares/test_putstr_fd.c:

Error in test 5: ft_putstr_fd("\nend!", fd: -1): expected: "abcdef\n1234\t567\nend!", content of the file: ""

For ft_putendl_fd, in /nfs/homes/usr/francinette/tests/libft/fsoares/test_putendl_fd.c:

Error in test 5: ft_putendl_fd("end!", fd: -1): expected: "\nabcdef\n1234\n567\nend!\n", content of the file: ""

And when I run all functions I get OK

✔ Compiling tests: fsoares (my own) ℹ Testing: ft_putendl_fd : OK ft_putstr_fd : OK

And the fd -1 really doesn't exist, I thought of solving it in a very simple way, only checking if fd is -1 and turning it into a positive number...

solismesmo commented 1 year ago

Solution of the problem: https://github.com/xicodomingues/francinette/pull/68