search

xiekeyang / oci-discovery

Contain the OCI Ref-engine Discovery specification and related specifications as an extention to the image specification.
Other
2 stars 1 forks source link

oci_discovery/ref_engine_discovery/__main__.py: Add --protocol and --port #11

Closed wking closed 7 years ago

wking commented 7 years ago

With --protocol replacing the old --https-only. With these changes, you can do things like:

$ python3 -m oci_discovery.ref_engine_discovery --protocol http --port 8080 '[::1]/app#1.0'

when testing locally.

Fixes #9 (although there are probably other ways we could address that too).

xiekeyang commented 7 years ago

LGTM It works correctly. Later we may support resolution like:

$ python3 -m oci_discovery.ref_engine_discovery 'localhost:8080/app#1.0'

Because consumers want this do be resolved automatically IMO.