search

xiekeyang / oci-discovery

Contain the OCI Ref-engine Discovery specification and related specifications as an extention to the image specification.
Other
2 stars 1 forks source link

squash! Discovery Tools for OCI Image #17

Closed wking closed 7 years ago

wking commented 7 years ago

Pull Go host-based image name parsing out into its own package and add tests.

A fixup with part of my suggestions for #16.

xiekeyang commented 7 years ago

And one more question: after this landed, go and python will coexist in this project. Should we keep improving only go, and remove python? Maintaining two languages seems to be redundant.

xiekeyang commented 7 years ago

LGTM

Some topics is still under discussion, we can patch them later.

wking commented 7 years ago

Should we keep improving only go, and remove python? Maintaining two languages seems to be redundant.

I don't mind keeping both in parallel during the mockup stage. If/when this project moves under the OCI, I think we want a spec-only repo with the *.md that is distribution-specific (everything but cas-engine-protocols.md and cas-template.md, which I think belong in image-spec). Then we can have go-distribution with the Go implementation and py-distribution (or whatever) with the Python implemenation. I don't mind if a Python repository ends up under the OCI or not; and I don't mind when it gets dropped from this repo. If you'd rather drop it now, I can create my own wking/oci-distribution repository now.

xiekeyang commented 7 years ago

If you'd rather drop it now, I can create my own wking/oci-distribution repository now.

I won't, keeping both is OK.