search

xiekeyang / oci-discovery

Contain the OCI Ref-engine Discovery specification and related specifications as an extention to the image specification.
Other
2 stars 1 forks source link

tools/refengine: Add a ref-engine protocol registry #23

Closed wking closed 7 years ago

wking commented 7 years ago

And add ref-engine references. This cleans up the ref-engine portion of the previous tools/ implementation. I have tried to touch the ref-engine discovery portion as little as possible, although there's some cleanup work still to do there as well.

I've removed the tools/ prefix from the tools/README.md example, because that README is already inside the tools directory.

There are also two more minor commits riding along:

A bit more motivation for both in their commit messages.

xiekeyang commented 7 years ago

Sorry I should have put comment 1 here.

wking commented 7 years ago

In current code it seems do nothing.

I agree in a net service context help to shutdown some handler gracefully...

That's what it's doing in this PR. It's also part of the other ref-engine interface calls, because a patricular ref-engine implementation could have slow/blocking code in any of them.

And besides graceful cancels, they're also useful for deadlines/timeouts.

xiekeyang commented 7 years ago

LGTM