search

xiel / embla-carousel-wheel-gestures

wheel interactions for Embla Carousel
https://embla-carousel-wheel-gestures.xiel.dev/react.html
MIT License
54 stars 8 forks source link

Support for embla-carousel v8 #179

Closed tobimori closed 1 year ago

tobimori commented 1 year ago

The plugin fails to initialize a carousel with the newest release candidate of embla-carousel, due to optionsHandler now being passed to the init function.

Changes need to be made similar to here: https://github.com/davidjerleke/embla-carousel/commit/f3fc83286fc7f9245b4ca2ea896812958e934ee0

I can provide a PR if needed.

jirbjirbjirb commented 1 year ago

would also love to see this enabled for v8. this issue is currently blocking me from updating our carousels and benefitting from v8 bugfixes

xiel commented 1 year ago

@tobimori PR would be welcome, otherwise I’ll try to fix this soon as well.

tobimori commented 1 year ago

@tobimori PR would be welcome, otherwise I’ll try to fix this soon as well.

Gonna do it tomorrow

xiel commented 1 year ago

It's done: https://github.com/xiel/embla-carousel-wheel-gestures/releases/tag/v8.0.0-rc03

smarlhens commented 6 months ago

Hey there 👋🏻 ,

I hope you are well.

It seems that embla-carousel has reached stable v8, do you plan to release a stable release of your library supporting it ?

Thanks in advance 🙏🏻