xiel / embla-carousel-wheel-gestures

wheel interactions for Embla Carousel
https://embla-carousel-wheel-gestures.xiel.dev/react.html
MIT License
54 stars 8 forks source link

NPM install dependency conflict #186

Closed me-0xe closed 10 months ago

me-0xe commented 1 year ago

Similar to this earlier issue Cannot install with NPM #182 There is a dependency conflict when installing via npm with the latest embla-carousel 8.0.0-rc7.

npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR! 
npm ERR! While resolving: embla-carousel-wheel-gestures@8.0.0-rc04
npm ERR! Found: embla-carousel@8.0.0-rc07
npm ERR! node_modules/embla-carousel

Suggestion It looks like the other plugins endorsed by the docs are tagging a release with the same rc as the main embla-carousel package. Maybe using the same approach when bumping the dependancy could help prevent future confusion for integrators?

Screenshot 2023-07-17 at 11 35 06 AM

sha237gh commented 1 year ago

+1, having the same problem. is there any way around this?

georgezikos commented 1 year ago

@sha237gh I just had it ignore the peer dependencies and install anyway using npm install embla-carousel-wheel-gestures --save --legacy-peer-deps and it seems to work just fine.

coreybrendan commented 11 months ago

Hey, gang! I'm also experiencing this conflict when attempting an npm install (on the latest version of Embla). Wondering if there's a fix queued for this issue? My team is wary of introducing a --legacy-peer-deps into prod.

hellomkreyes commented 11 months ago

Experiencing the same problem as well! I want to implement the plugin in a production codebase, so I kinda want to avoid having to use the --legacy-peer-deps workaround.

davidjerleke commented 11 months ago

Hi @hellomkreyes, @coreybrendan, @me-0xe, @georgezikos, @sha237gh.

I think we need to add a tilde (~) sign before the package version here to avoid this happening every time a new minor version of embla-carousel is released.

Feel free to open a PR for this.

Best, David

xiel commented 11 months ago

Sorry had busy weeks, should be fixed now. I was not aware the tilde would work for prereleases. 🙏

Please try again with embla-carousel-wheel-gestures@8.0.0-rc05 📦 I tested it with yarn and npm (9.5.1) and it worked like that.

Cheers and thanks for your patience.

me-0xe commented 10 months ago

Thanks for the response. Appreciate the effort that goes into Embla and the plugins!