search

xieziyu / ngx-echarts

An angular (ver >= 2.x) directive for ECharts (ver >= 3.x)
https://xieziyu.github.io/ngx-echarts/
MIT License
1.11k stars 197 forks source link

Angular9 support #224

Closed hijamoya closed 4 years ago

hijamoya commented 4 years ago

Please upgrade to angular9

 Entry point 'ngx-echarts/core' contains deep imports into '/Users/jam/go/src/git.eng.lativ.com/eng/lativ/erp/frontend/node_modules/echarts/lib/echarts'. This is probably not a problem, but may cause the compilation of entry points to be out of order.
xieziyu commented 4 years ago

@hijamoya It seems I need to rewrite the implementation of custom build. 😢 I'm planning to rewrite the whole project to support angular 9. Thank you for your report.

arthurflor23 commented 4 years ago

Hi, I'm using Angular 9.1 now and I didn't have this problem. The module works fine here.

ciukstar commented 4 years ago

Same warning for me: Warning: Entry point 'ngx-echarts/core' contains deep imports into '<project_home>/node_modules/echarts/lib/echarts', '<project_home>/node_modules/echarts/dist/echarts.min.js'. This is probably not a problem, but may cause the compilation of entry points to be out of order.

msyesyan commented 4 years ago

@xieziyu do you have a plan about when to finish the angular 9 support? ^_^

xieziyu commented 4 years ago

Please upgrade to ngx-echarts v5.0.0

ciukstar commented 4 years ago

Please upgrade to ngx-echarts v5.0.0

Successfully updated to ngx-echarts@5.0.0. No more warnings. Many thanks.

vishnu-dev commented 4 years ago

Shouldn't this be closed @xieziyu? The warning disappears after upgrading. I thought this is still work under progress until I saw the comments.