xif-fr / dokuwiki-plugin-catlist

DokuWiki plugin to list pages and namespaces recursively in nested lists
https://www.dokuwiki.org/plugin:catlist
8 stars 15 forks source link

Issue with Friendly URLs #11

Closed MikeWills closed 6 years ago

MikeWills commented 6 years ago

I love the plugin, however, I found an issue when using with Friendly URLs. When adding a new page from the listing the URL will be incorrect creating an unintended URL (https://mydomain.com/doku.php/podcast/ddop/s/test&do=edit). I am then presented with the "This topic does not exist yet" view then I have to click edit. When I do that page name becomes test_do_edit. I believe a test should be done to see if the setting userewrite is set to "DocuWiki Internal" then append a ? instead of an &.

xif-fr commented 6 years ago

The intended URL should be https://mydomain.com/doku.php/podcast/ddop/s/test?do=edit right ? I already take into account userewrite, but I probably miss-implemented the case userewrite=2

MikeWills commented 6 years ago

Yes

xif-fr commented 6 years ago

I think I fixed it. Sorry for the looong delay. Could you check the last version (https://github.com/xif-fr/dokuwiki-plugin-catlist/archive/master.zip) ?

MikeWills commented 6 years ago

Works great now!

Mike Wills http://mikewills.me Ph: 507-933-0880

On Sun, Sep 9, 2018 at 9:07 AM Félix Faisant notifications@github.com wrote:

I think I fixed it. Sorry for the looong delay. Could you check the last version ( https://github.com/xif-fr/dokuwiki-plugin-catlist/archive/master.zip http://url) ?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/xif-fr/dokuwiki-plugin-catlist/issues/11#issuecomment-419718397, or mute the thread https://github.com/notifications/unsubscribe-auth/AAIgKfPhUTG6-58B5BnTHuCHOIfrdqbVks5uZSCugaJpZM4V7yS4 .

xif-fr commented 6 years ago

The 2018-10-04 version should do it by the way.