search

xiidea / EasyAuditBundle

A Symfony Bundle To Log Selective Events
http://xiidea.github.io/EasyAuditBundle/
MIT License
89 stars 22 forks source link

Incompatibility for 1.4.6 ->1.4.9 #39

Closed pausf closed 5 years ago

pausf commented 5 years ago

Hi Ronin,

Versions 1.4.* should be compatible with each other and from 1.4.6 to 1.4.9 many errors occur. For example the function "getBestCandidatePropertyForIdentify" is no longer in the class EntityEventResolver.

Version 1.4.* should only be for improvements or bug fixes not such big code changes.

Thank you very much for the development

ronisaha commented 5 years ago

Sorry for the inconvenience, As i have treated the Default Entity Resolver as example implementation, I did made that changes ignoring the backward compatibility(My Bad). If you like the old implementation, please instead of extending, you can copy the content from https://github.com/xiidea/EasyAuditBundle/blob/1.4.6/Resolver/EntityEventResolver.php

For future reference I'll add an BC breaking note in the readme.

From now on I'll try harder to keep the backward compatibility.

Thank for your feedback.

pausf commented 5 years ago

Many thanks and good job