search

xil-se / xildebug_sw

XilDebug is a CMSIS-DAP compliant debugger, UART bridge and power profiler all in one package.
5 stars 1 forks source link

Share more files between stm32 platforms #95

Closed kbeckmann closed 6 years ago

kbeckmann commented 6 years ago

Moves shared files to platform/stm32_common/... in order to reduce copy-paste and having to fix bugs in multiple places every time.

kbeckmann commented 6 years ago

~And no this doesn't fix the macos problem. It should however make the hid communication more reliable.~ Meant to post that on #96

kbeckmann commented 6 years ago

huh? i fixed that. are you commenting on old commits?

include "hal_errors.h"

include "hid_internal.h"

include "platform/platform.h"

include "platform/usb/hid.h"

include "platform/usb/usb.h"

include "stm32_hal.h"

include "usb/core.h"

include "usb/ctlreq.h"

that's how it looks for me.

On Mon, Jun 11, 2018 at 4:06 PM arturo182 notifications@github.com wrote:

@arturo182 commented on this pull request.

In platforms/stm32_common/usb/hid.c https://github.com/xil-se/xildebug_sw/pull/95#discussion_r194307206:

@@ -8,7 +8,7 @@

include "platform/usb/usb.h"

include "usb/core.h"

include "usb/ctlreq.h"

-#include "stm32f0xx_hal.h" +#include "stm32_hal.h"

include "hid_internal.h"

Bad @kbeckmann https://github.com/kbeckmann

— You are receiving this because you were mentioned.

kbeckmann commented 6 years ago

@arturo182 https://github.com/xil-se/xildebug_sw/pull/95/commits/1664d74c2817338c85eedffa265f6f264a1f772c#diff-236352a616f0ab0c9234bbd261239d85L6

kbeckmann commented 6 years ago

meep. i fixed the stuff you complained about.