search

ximion / appstream-dep11

Python module to handle Debian DEP-11 metadata
https://github.com/ximion/appstream-generator
GNU Lesser General Public License v3.0
3 stars 3 forks source link

Add a date to the header document #17

Closed iainlane closed 8 years ago

iainlane commented 8 years ago

& avoid updating the output more than is necessary so that the file is stable.

This is so we can track if the remote side (dak or launchpad and apt) is pulling from us correctly.

iainlane commented 8 years ago

OK I just pushed some updates, please re-review. I wasn't sure that I understood the comment about the hints file correctly (don't know why this is necessary), so that's a separate commit - you can squash them when merging if you want. The field is now called Time and we use has_ignore_reason to see if there is new stuff.

ximion commented 8 years ago

Looks good to me! Sorry for not being able to merge this today, will do it tomorrow! About the hints: Well, if we had exactly zero new components, we don't need to re-write them either, but that would need a second check. One for "are there any valid components?" and one for "are there any invalid components?".

iainlane commented 8 years ago

Ah right, because hints describes the errors - I get it. And there's already a check to skip the suite in the "0 new components" case, so I think we are good.

iainlane commented 8 years ago

(conflict resolved)

ximion commented 8 years ago

Patch applied to master, Thanks!