search

ximion / appstream-generator

A fast AppStream metadata generator
GNU Lesser General Public License v3.0
43 stars 29 forks source link

Update README.md with new dependencies #127

Closed baryluk closed 10 months ago

baryluk commented 10 months ago

libfreetype6-dev is a deprecated (long time ago) transitional package. Use proper one instead.

Add appstream compose header files.

Add yarnpkg, as otherwise default build instructions will not work.

baryluk commented 10 months ago

Honestly, I do not know where freetype is even used in the source code. I could not find any use of it.

And if I remove all freetype related header files from my system it still builds just fine. (Also in Debian I see they do not list freetype as a dependency - https://salsa.debian.org/pkgutopia-team/appstream-generator/-/blob/debian/master/debian/control )

ximion commented 10 months ago

Honestly, I do not know where freetype is even used in the source code. I could not find any use of it.

I think you can drop it, the code that used it has been spun out into an external library and the generator itself no longer needs it :-)

baryluk commented 10 months ago

Lets merge this as is. Can clean more in separate PR.

I think it is now more than just freetype that is not required. Does it depended on cairo and pango directly anymore?

baryluk commented 10 months ago

You can ignore Debian testing build failure. This is due to https://tracker.debian.org/pkg/glib-d still not migrating from unstable to testing. (Will do in few days - appstream-generator does build fine with one from unstable, I tested it few minutes ago).

baryluk commented 10 months ago

Oh. @ximion I did not realize that is you Matthias. :)

ximion commented 10 months ago

Does it depended on cairo and pango directly anymore?

No, documentation is quite outdated since a bunch of this code was rewritten in C (pretty my all the nasty stuff is in compose now).

Oh. @ximion I did not realize that is you Matthias. :)

Way too much stuff in few hands ;-)

There's no reason not to merge this change, but to really fix this we'd need to update the whole dependency list. The one at Debian should be accurate.