snap/ubuntu fixes - Githubissues

ximion / appstream-generator

A fast AppStream metadata generator

GNU Lesser General Public License v3.0

44 stars 29 forks source link

snap/ubuntu fixes #87

Closed iainlane closed 3 years ago

iainlane commented 3 years ago

Hope it's ok to bundle these up...

Couple of things here

Fixing that crash we saw on Ubuntu runs, which was due to a bug when we close a package then go on to reopen it later.
Some snap build fixes that were needed when I tried a newer snapcraft. Please could you try building it in your way, to make sure I didn't break that... (maybe the CI will do this)

ximion commented 3 years ago

Except for that nitpick, this looks good to me! It's very odd that these methods in DebPackage had no locking whatsoever - likely the package was only to be used from one thread originally, until we started hunting down icons all over the place. Thank you for the debugging effort and Snap-modernization!