search

xinber / aforge

Automatically exported from code.google.com/p/aforge
Other
0 stars 0 forks source link

VideoFileWriter should implement IDisposable #261

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Usually all writers in the .NET framework implement IDisposable besides having 
a Close method so you can include them in a "using" statement (to ensure file 
operations are flushed out even when exceptions are thrown, etc).

It would be helpful if Aforge.Video.FFMPEG.VideoFileWriter and possibly all 
other writers would follow this design pattern as well. This post provides some 
advice: 
http://stackoverflow.com/questions/630955/how-to-implement-dispose-pattern-with-
close-method-correctly-ca1063

Keep up the excellent work!

Original issue reported on code.google.com by goncaloc...@gmail.com on 4 Nov 2011 at 3:25

GoogleCodeExporter commented 9 years ago 
Implemented IDisposable interface for VideoFileReader and VideoFileWriter 
classes.

Committed in revision 1632. Will be released in version 2.2.3.

Original comment by andrew.k...@gmail.com on 17 Nov 2011 at 9:51

GoogleCodeExporter commented 9 years ago

Original comment by andrew.k...@gmail.com on 12 Dec 2011 at 9:16