vDNS Wontfix

[GoogleCodeExporter]

Please read issue 8, issue 72 and have a close look on:

http://tldp.org/LDP/abs/html/internalvariables.html#APPREF

to understand the differences between ${var[*]} ${var[@]} and quotation.

Also please run the shellscript that follows the given URL above under
paragraph "Example 9-6. arglist: Listing arguments with $* and $@"
and fix it another time.

WONTFIX regards
Thomas

Original issue reported on code.google.com by thomas.r...@googlemail.com on 4 Oct 2009 at 7:03

[GoogleCodeExporter]

Please see the following Discussion Group thread:
http://groups.google.com/group/tunnelblick-discuss/browse_thread/thread/f164544d
49fbd50f

Particular the comments by Diego Rivera, especially his October 3, 2009 comment.

As noted in Issue 72, the script for which you gave a patch was replaced 
(months ago); the patch you submitted 
no longer applies.

Original comment by jkbull...@gmail.com on 4 Oct 2009 at 7:36

[GoogleCodeExporter]

I'm referring to "Tunnelblick version 3.0b18 2009-09-23", for example:

        ${NO_DNS}d.add ServerAddresses * ${vDNS[*]}
and
        ${AGG_DNS}d.add ServerAddresses * ${STATIC_DNS} ${vDNS[*]}

Would you please try to run that advanced bash scripting guide example for me 
comparing

foo bar and
"foo bar"

Thanks.

Original comment by thomas.r...@googlemail.com on 4 Oct 2009 at 7:50

[GoogleCodeExporter]

Thank you for the specifics. We'll look into it.

Original comment by jkbull...@gmail.com on 4 Oct 2009 at 8:17

[GoogleCodeExporter]

There is a difference, but in this case we don't care because there will never 
be any
spaces as part of the entries added to the arrays.  Thus, we're not interested 
in
being able to quote each entry separately.

In particular, the entries in the arrays are always IP addresses (they MUST be, 
since
they're either DNS or WINS server entries, which can't be names).  As we all 
know, a
space is not an allowed character as part of an IP address.  Thus, * and @ will
produce the same result regardless.

Thus, this is a WON'T FIX, b/c the script is working as designed and there is 
no need
to change this behavior.

Original comment by diego.ri...@rbxglobal.com on 4 Oct 2009 at 11:42

[GoogleCodeExporter]

And because of "it's forbidden" it's keeping people from doing wrongs? No 
whatsoever
error-treatment, because doing wrongs is not allowed!

Cheers

Original comment by thomas.r...@googlemail.com on 5 Oct 2009 at 6:42

[GoogleCodeExporter]

I'm sorry, but I don't understand comment #5. What is being forbidden? What is 
the error that needs to be 
treated?

If I understand this correctly, the patches allow the scripts to handle spaces 
in particular script variables 
(which are entries in an array). However, the variables never have spaces in 
them, so the patches are not 
needed. We know the entries never have spaces in them because they are 
generated that way by the operating 
system. The entries are not entered by the user, so there is no possibility 
that the user enters them wrong.

In other words, although the patches may have been good for the original 
scripts, they are not needed in the 
current scripts, because the only places they could be applied already work 
correctly without the patches and 
there is no possibility that an error by the user could make them not work 
correctly without them.

Original comment by jkbull...@gmail.com on 5 Oct 2009 at 11:05

[GoogleCodeExporter]

Original comment by jkbull...@gmail.com on 17 Nov 2009 at 5:50

• Changed state: WontFix
• Added labels: Type-Other
• Removed labels: Type-Defect