search

xini / silverstripe-silvershop-stripe

BSD 3-Clause "New" or "Revised" License
4 stars 7 forks source link

Silverstripe 5? #11

Open Firesphere opened 9 months ago

Firesphere commented 9 months ago

Is this module directly compatible with SS5?

xini commented 9 months ago

@BettinaMaria98 and @wernerkrauss, have you tested this in SS5 yet?

BettinaMaria98 commented 9 months ago

@xini no, I haven't tested it with SS5

digitweaks commented 7 months ago

@Firesphere I made it work with SilverStripe 5 by modifying the composer.json and removing the "suilven/silverstripe-track-member": "~1.0" and adding its code directly to the module. Though I only have it partially working as the form for credit card shows up but without the input fields.

ProbablyTony commented 4 months ago

I got it working with what @digitweaks mentioned after doing a vendor-expose

xini commented 4 months ago

@digitweaks @ProbablyTony excuse my ignorance, I haven't used this module for a while. But why is the functionality from "suilven/silverstripe-track-member" even required? Where is that used?

ProbablyTony commented 4 months ago

I don't think it is even used.

digitweaks commented 4 months ago

@xini @ProbablyTony Apparently it's used to track user logins and build some reports on users activity for the shop's backend

xini commented 3 months ago

@digitweaks @ProbablyTony can you please test the 2.0.0-beta1 tag with SS5?

I have removed "suilven/silverstripe-track-member" completely and it worked for both payment gateways.

Let me know how you go.

digitweaks commented 3 months ago

@xini Technically I'm using a custom Omnipay gateway using Stripe PHP package so I don't know how this implementation behaves.