search

xini / silverstripe-silvershop-stripe

BSD 3-Clause "New" or "Revised" License
4 stars 7 forks source link

Stripe Payment Intents #7

Closed MatMorrisParker closed 9 months ago

MatMorrisParker commented 3 years ago

Are there any plans to upgrade this to support Stripe Payment Intents (or is there a way to enable it that I've missed)?

xini commented 3 years ago

Hi Mathew, I don't have any plans for this just yet. But certainly sounds reasonable. Happy to accept PRs if you want to have a go at it? Cheers

MatMorrisParker commented 3 years ago

Thanks for the swift response @xini ! I'm happy to give it a go, although I'll be honest I'm not entirely confident I'll be of much use

Do you have any pointers of what would need to be updated?

xini commented 1 year ago

@wernerkrauss and @BettinaMaria98 I believe you have implemented payment intends in a fork of this module? Is that something we could merge back? Cheers

xini commented 1 year ago

https://github.com/BettinaMaria98/silverstripe-silvershop-stripe/tree/paymentintents

BettinaMaria98 commented 1 year ago

@xini Yes we think that it could merged back, I opened a pull request to get our changes back to your module! https://github.com/xini/silverstripe-silvershop-stripe/pull/10/

xini commented 1 year ago

@BettinaMaria98 thank you very much, how exciting! I believe your changes are fully backwards compatible? Or do we need a new major version?

BettinaMaria98 commented 1 year ago

@wernerkrauss what do you think?

xini commented 9 months ago

implemented in #10. Thanks @BettinaMaria98 and @wernerkrauss