Closed xinmiaow closed 7 years ago
Hi Xinmiao,
Your repo is very organized and it is very easy to navigate your homework.
You have completed the required tasks for the homework.
You have divided the homework in different sections with clear labeling which makes things easy to follow and read.
You showed a good example for reshape activity. The relationship between the life expectancy of Canada and America is very clear in this format.
You explored different join functions with detailed description.
Good practice of obtaining new data of country info from geonames. It is useful to learn about different sources of dataset. I didn't think of to use the data sources from outside and I think it is tricker to manipulate those. Also, I learnt what problems to expect when introducing a new data set from outside.
You also included a report on your progress.
It would be great if you also explore the merge and match functions and compare them to join functions but it is not mandatory.
Overall good homework. Check plus.
Hi Xinmiao,
You’re assignment is very well done. I appreciate the organized readme file and formatting (especially the inclusion of references and extensive hyper-referencing). It was also nice to read the documentation of your data collection, it’s nice to know it’s not just me that has problems getting more data!
Excellent choice of datasets to exemplify the functionality of _join
functions. This made it very clear what each function was doing. I learnt about the by
option from your work which seems very useful in situations where the same variable might appear in multiple columns (e.g. if Oceania was called Australia instead).
One small recommendation I would make is to split up your code chunks when you have multiple outputs. For example, at the beginning of the assignment you make the life expectancy kable and plot in the same code chunk. If you split them up, it’s easier to comment on each one separately and highlight their relevance (and shorten the time I need to remember your comments for). I had a similar moment of brief confusion at the beginning of the second part when you describe the creation of the countryinfo
dataset, but immediately after start manipulating gapminder. A minor quibble in an excellent (check plus) assignment.
All the best, Alistair
Hi @xinmiaow here are some comments concerning your homework: General data reshaping and relationship to aggregation: Yes (2) Join, merge, look up: Yes (1) Progress report: Yes Extras (optional; merge/match): No
+You did a great job, Your marks will be distributed later, Regards, Pedro G.
SHA: 917b295
Links to my files related to HW04:
The main repo for homework: here
hw04 folder: here.
Files inside hw04:
README.md
hw04_Gapminder.Rmd
hw04_Gapminder.md