Closed xinmiaow closed 7 years ago
Hi @xinmiaow 😄
Your homework 5 is very organized, which helps me to find the files easily. (I can find the homework 5 documents in your "README" and issue part).
You have finished all the required tasks and I can repeat all your process and get the results in homework 5.
Here are some comments:
For the “Drop Oceania” part, I think you could also add some details of how “Drop Oceania” will affect the level of the “country”.
For the reorder the levels of country part, what you have done was correct, and I also want to suggest you plot the original order of countries firstly and then to use fct_reorder
function to reorder the levels. Using the fct_reorder
comparison, you could find how the function changes the order.
I like your "explore the effects of reordering a factor and factor reordering
coupled with arrange ()" part, and I learned a new function multiplot
. This is a very useful function when we want to plot more than one graph and combine them together.
For the “File I/O” part, just a small suggestion: you could try to add some explanations after each command next time.
You did very well for visualization part, especially for the colors. It is super vivid, which I could easily find the outstanding points. In addition, you use two types of plots, one is histogram and another one is scatter plot by changing the type, so it is very comprehensive. For me, I learned theme_calc()
function from you. And you could also try pair ()
function when you only want to plot Life Expectancy against each Continent
.
Moreover, your "README" file is informative and well formatted, and I enjoy looking through your assignment !
Dear @xinmiaow,
Well done on homework 5! You have used the Gapminder dataset to illustrate the exercises.
Gapminder version: drop Oceania: task successfully completed ! You removed Oceania factor, and dropped the unused level Oceania.
Reorder the levels of country or continent: task successfully completed ! You reordered the levels of continent according to descending mean of gdpPercap. You then reorderd the country according to the maximum population of each country.
Explore the effects of arrange(): task successfully completed !
File I/O: task successfully completed ! You used both write_csv()
and read_csv()
as well as saveRDS()
, well done. You thought me something new about RDS in relation to the factor ordering and I thank you for that :)
Visualization design: You made several plot. You thought me that gapminder had already a color scheme that you can call by scale_fill_manual(values=continent_colors)
. You used gradient as well.
Save a plot to file and call it back: task successfully completed !
Document your process: You process is well documented and we can follow your train of thought easily.
Clean up your repo: your repository is very organized ! Your top level README file also has links to individual homework (and broken down link to individual files). Individual homework README files are also informative.
For future reference, when I looked at your homework code for the multiplot, which is a great idea. I also saw that you used the R Cookbook here, so I would recommend you put the reference in your homework for source attribution and future reference. For example, you could refer to the github of Jenny Brian here for the plot you saved and displayed back.
If you have any questions, please don't hesitate to let me know.
Warm regards, My Linh Thibodeau
Hi My Link Thibodeau @mylinhthibodeau,
Thanks for your review and your comment in such a pretty format. I am supposed to do that next time. It make me so comfortable to read it.
For your additional information, thanks for your recommendation. We are supposed to be honest and respect the authors who provides us with valuable resources.
To avoid any concern, I do put all the links to what I borrow from other authors in Reference part in my Rmd and md files. I just use all the resources in STAT545 website. I did not google the origins of these resources.
You can check it here
I really appreciate your review.
Thanks a lot, Xinmiao
Dear @xinmiaow,
You have no reason to be concerned at all, so please do not worry yourself !! This was more of a general recommendation. I am currently working on some publications and one of the most important thing is to ensure that all the correct sources referenced, so I just wanted to mention it to you early so that you can get into these habits for your future academic work.
Warm regards, My Linh
Hi @xinmiaow here are some comments about your homework: Reorder a factor: yes File I/O: yes Implement visualization: yes Write data to file: yes Clean up: yes Extras: yes
Great homework, Your marks will be distributed later, Regards, Pedro G.
SHA: 2326262
Links to my files related to HW05:
The main repo for homework: here
hw05 folder: here.
Files inside hw05: