HW07 Ready for Grading

[xinmiaow]

SHA: cfb12fc

Links to my files related to HW07:

• The main repo for homework: here

• hw07 folder: here.

• Files inside hw07:

  1. 0_download_data.R

  2. 1_exploratory_analyses.R

  3. 2_statistical_analyses.R

  4. 3_generate_figures.R

  5. Makefile

  6. hw07_Gapminder.Rmd

  7. hw07_Gapminder.md

Sorry for collecting so many files under hw07 folder. Hope the navigation part above can help you find the files quickly. In addition, I report the process in the README.md under hw07 folder . Please have a look at it and get some ideas about my workflow.

Thanks a lot, Xinmiao

[margotgunning]

Hi @xinmiaow,

First, in your main README, I like how you have the latest HW files at the top. Your HW07 README was very thorough, and I really liked how you gave a more detailed description of all the code files used for automation with inputs, outputs ect; it's definitely something that I should have included in my own repo.

You produced a lot of graphs in the exploratory analysis section of the report; I liked how you had short/concise interpretation of the plots, and used it to justify how you re-ordered the data. I liked the layout of your LifeExp over Years graphs. The only addition I would have liked to see here would be some commentary on the outputs; however, you did mention how you picked the best/worst fitted countries based on the size of the residual error above, which was nice.

Your code files were straight forward with effective commentary. I liked how you selected the best/worst countries. I did not use the same approach, and I think yours demonstrates a better coding style, so it was nice to learn something new reading your code!

Overall, you created a very concise, and straightforward assignment. Well done.

Cheers, Margot

[jardnzm]

Hi @xinmiaow ,

• You readme file contains all sort of information and makes people easily to go to each part. The description below gives a basic idea about what you did in this homework.

• In your first exploratory_analyses part, plot some nice-looking figures to give a glance about datasets and then reorder the data. check

• In statistical_analyses, write down a function that will output coefficients and residuals for lm, and use order to automatically choose best fit countries, which makes this file can be applied to other dataset.

• In the last two parts, you automate the pipeline and render your RMarkdown report, the report looks great. It seems like you understand the mechanics behind automating workflows, which is important. Overall, a very solid work and finish the requirements!

Best, Ziming

[ksedivyhaley]

Three or more scripts, an Rmd, and a Makefile: Yes Starts by downloading data, ends with Rmd: Yes The output of each is the modified input of the previous step: Yes Includes some analysis and at least one figure: Yes Makefile includes all scripts and Rmd with correct dependencies: Yes Makefile runs: Yes Bonus: Imported data, embedded figures. Reflection: No

Comments:

• Despite large numbers of files (try making a subfolder for figures), the links and naming/numbering conventions make the assignment easy to navigate.
• Nice functional pipeline and Makefile. Everything works and is easy to understand.
• Report is clear and makes good use of the pipeline's output.
• Your README summary is helpful and mostly accurate – however, hw07_Gapminder.Rmd just outputs the md – the rest of the files are inputs. Your Makefile gets this correctly.
• I'm noticing that you save lm_fits.tsv without using it later in the pipeline (which is fine, the fits are good to have in case of further analysis) but also that you calculate worst fits without saving a file at all – any reason for that?

Your mark will be distributed later. If you would like more feedback, please feel free to message me on slack.

[ksedivyhaley]

Oh - missed something! It's important to list the R scripts you're running as dependencies of each step, along with the inputs. This ensures that if you change one of your scripts, you'll re-run any steps that use those scripts. Otherwise Make thinks everything is up to date.