xinntao / ESRGAN

ECCV18 Workshops - Enhanced SRGAN. Champion PIRM Challenge on Perceptual Super-Resolution. The training codes are in BasicSR.
https://github.com/xinntao/BasicSR
Apache License 2.0
5.86k stars 1.04k forks source link

Please stop changing the state keys #128

Open rlaphoenix opened 2 years ago

rlaphoenix commented 2 years ago

As you can see here: https://github.com/rlaphoenix/VSGAN/blob/a81c177f00ee8cfb5bbc847c0da0ce2b5ad9d4ec/vsgan/archs/ESRGAN.py#L42

I need to manually do some key name replacing and regex checks to be able to support all models of all 3 types of RRDBNet archs you have done for: Original ESRGAN, Later ESRGAN (Near BasicSR), as well as Real-ESRGAN.

Please try not to change the state keys so much as it breaks compatibility with old models for testing and gives other devs a headache to try support them all. Thanks.

lvchuandong commented 2 years ago

这是来自QQ邮箱的假期自动回复邮件。你好,我最近正在休假中,无法亲自回复你的邮件。我将在假期结束后,尽快给你回复。