search

xinntao / facexlib

FaceXlib aims at providing ready-to-use face-related functions based on current STOA open-source methods.
MIT License
807 stars 143 forks source link

wrong kernel in guassian blur ? #25

Open tavihalperin opened 1 year ago

tavihalperin commented 1 year ago

Hi,

you use twice gaussian blur with the same (101,101) kernel should it be split into two 101x1 and 1x101 kernels?

or is it just a duplicate?

https://github.com/xinntao/facexlib/blob/9557a45094f3e4619fc5c145ef76adf9710fd054/facexlib/utils/face_restoration_helper.py#L317

woctezuma commented 1 year ago

Nicely spotted. I cannot answer.

Just to be clear for xinntao, the issue is about the duplicate lines: https://github.com/xinntao/facexlib/blob/9557a45094f3e4619fc5c145ef76adf9710fd054/facexlib/utils/face_restoration_helper.py#L316-L318

Edit: This was added with ParseNet. I see it is used as well with GPEN.

tavihalperin commented 1 year ago

Thanks for the pointer, I'll post it there as well