xinntao / facexlib

FaceXlib aims at providing ready-to-use face-related functions based on current STOA open-source methods.
MIT License
810 stars 143 forks source link

Bug: Changed float to float64 for newer numpy #38

Open vltmedia opened 1 year ago

vltmedia commented 1 year ago

Numpy 1.23+ was crashing because of the np.float value. This fixes the possible crash/block using the recommended change.

Error:

File "f:\Env\Lib\site-packages\numpy\__init__.py
", line 305, in __getattr__
    raise AttributeError(__former_attrs__[attr])
AttributeError: module 'numpy' has no attribute 'float'.
`np.float` was a deprecated alias for the builtin `float`. To avoid this error in e
xisting code, use `float` by itself. Doing this will not modify any behavior and is
 safe. If you specifically wanted the numpy scalar type, use `np.float64` here.    
The aliases was originally deprecated in NumPy 1.20; for more details and guidance 
see the original release note at:
    https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations
woctezuma commented 1 year ago

np.float was a deprecated alias for the builtin float. To avoid this error in e xisting code, use float by itself. Doing this will not modify any behavior and is safe. If you specifically wanted the numpy scalar type, use np.float64 here.

Thanks! I don't know what is better: float or np.float64. Maybe the former as suggested by the error message?

vltmedia commented 1 year ago

Yup no problem! It seems np.float64 get's through it on all of computers we tested on so I'd go with that for compatibility.