xinrong-meng / knowledge-sharing

Hub for curated insights and resources on software systems and technologies
381 stars 111 forks source link

docs: fix images fail to load #4

Closed hongbo-miao closed 3 weeks ago

hongbo-miao commented 3 months ago

Thanks for sharing! This pull request just fix the images. Right now, they're not loading because of an issue with the Content Security Policy which can be seen in the browser console:

Refused to load the image '' because it violates the following Content Security Policy directive: "img-src 'self' data: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com".

image

This change will allow images to be displayed. You can preview it here.

One solution is to upload your image at https://github.com/xinrong-meng/knowledge-sharing/issues/new and include the link. This way, the images will show up correctly. ☺️

xinrong-meng commented 3 weeks ago

Thank you for the fix! That's so helpful