search

xinthink / react-native-material-kit

Bringing Material Design to React Native
https://rnmk.xinthink.com
MIT License
4.84k stars 578 forks source link

Disabling features on controls #185

Open badnorseman opened 8 years ago

badnorseman commented 8 years ago

Is anybody looking to or working on adding disable feature on controls, buttons or textfield?

If not, I would like to contribute. Thanks.

Crash-- commented 8 years ago

Hi @urbanvikingr. Go ahead, send a PR... Feel free to participate without asking us ;)

Crash-- commented 8 years ago

See #176 for a start. But I'd really like an harmonized API between components for this feature (with a deprecated message if you need to BC break) ;)

badnorseman commented 8 years ago

Would it be appropriate to offer a $200 bonus to someone to add disabling on buttons and controls within a week?

alexprice1 commented 8 years ago

@urbanvikingr I have been beyond busy with my day job. Hoping to get this out in the next week. The pattern is already established from that PR if you want to contribute, otherwise I'll try to implement it this week.

badnorseman commented 8 years ago

@alexprice91 I am in boat as you in regards to client work. I would like to invite my developer Danny @israelidanny to this discussion. He contributed to the slider. Do you have specs to how you would like to have this implemented?

Crash-- commented 8 years ago

@urbanvikingr We're currently working on a few solutions. As soon as I've something to show for a few components, I'll open a PR to engage the discussion and to implement it on other components. We've not currently any specs, we're testing several paths.

And when I say ASAP, I think I'll be able to show something today or tomorrow. Every idea is good to take, so if @israelidanny has some ideas, don't hesitate to share ;).

badnorseman commented 8 years ago

@Crash-- Any updates on specs. If not, @israelidanny will contact you to discuss. Otherwise, please share your specs and we would like to contribute.

badnorseman commented 8 years ago

How can we contribute on this? We would like to help as we need this for a client project, but we would like to follow your specs or perhaps we can implement a suggestion.

My thought would be to have a disabled, optional bool as input to avoid setting this bool every you need the sliders or buttons without disabling feature. @Crash-- @alexprice91 @israelidanny

etodanik commented 8 years ago

I published a first PR for this kind of functionality: https://github.com/xinthink/react-native-material-kit/pull/192