xinweichong / pe

0 stars 0 forks source link

Name field does not allow for special characters #1

Open xinweichong opened 1 week ago

xinweichong commented 1 week ago

Screenshot 2024-11-15 at 16.14.50.png

input used: add n/John s/o p/98765432 e/johnd@example.com r/05-0523 a/311, Clementi Ave 2, #02-25 t/Floor10 t/Table Tennis

The name field does not allow for special characters such as "/" which may be present in some people's official names, causing the app to be restrictive in its usage. Consider allowing special characters to be passed as input!

soc-pe-bot commented 1 week ago

[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Use of "/" not allowed for name field

image.png

Users are not allowed to enter "/" for name field even though it is possible for names to use "/". Disallowing s/o in a person name because / is used as a command delimiter can cause a major problem if the input is expected to match the legal name of the person. Therefore, it would be better if "/" was allowed


[original: nus-cs2103-AY2425S1/pe-interim#1786] [original labels: type.FeatureFlaw severity.Low]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

The application was not designed with the legal names of each resident being used by the dorm manager in mind, given that it is unlikely that records from the app will be used for legal purposes. Specifically, we expected the dorm manager to use this to informally keep track of their residents, and expected them to name the students however they wanted in the application.

Accordingly, we allowed characters like commas, apostrophes, dashes and even numbers to make it easier for the user to format the names but did not implement inclusion of the slash character to prevent errors that may arise when parsing the command and its parameters.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your reason]


## :question: Issue response Team chose [`response.NotInScope`] - [ ] I disagree **Reason for disagreement:** [replace this with your reason]
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your reason]