search

xinxinlx / openjpeg

Automatically exported from code.google.com/p/openjpeg
Other
0 stars 0 forks source link

Remove old API (pre v2?) #268

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
dashboard reports static functions not being used in the code anymore:

/home/otbval/Dashboard/nightly/OPJ-Release/src/src/lib/openjp2/j2k.c:4680:10: 
warning: 'opj_j2k_read_eoc' defined but not used [-Wunused-function]
/home/otbval/Dashboard/nightly/OPJ-Release/src/src/lib/openjp2/j2k.c:4791:10: 
warning: 'opj_j2k_write_all_coc' defined but not used [-Wunused-function]
/home/otbval/Dashboard/nightly/OPJ-Release/src/src/lib/openjp2/j2k.c:4812:10: 
warning: 'opj_j2k_write_all_qcc' defined but not used [-Wunused-function]

Those functions should now be removed.

Original issue reported on code.google.com by mathieu.malaterre on 3 Mar 2014 at 8:16

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r2535.

Original comment by mathieu.malaterre on 3 Mar 2014 at 8:17

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r2536.

Original comment by mathieu.malaterre on 3 Mar 2014 at 8:27

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r2537.

Original comment by mathieu.malaterre on 3 Mar 2014 at 8:30

GoogleCodeExporter commented 9 years ago

Original comment by mathieu.malaterre on 3 Mar 2014 at 11:41

GoogleCodeExporter commented 9 years ago 
Are you sure of r2537 ? These functions are part of the MQ-coder and AFAIU the 
codebase, they are required in the decoding process (at least those from t1.c). 
Does the test suite still run with those functions removed ?

Original comment by antonin on 3 Mar 2014 at 11:32

GoogleCodeExporter commented 9 years ago 
All functions were declared as `static` and thus could only be used within the 
translation unit (not exported outside the C file). I do believe the gcc 
compiler was correct in reporting those functions as never used.
The test suite seems to be running quite well. This may be an artifact from the 
v2 transition and a left over appeared during this step.

Original comment by mathieu.malaterre on 4 Mar 2014 at 8:50

GoogleCodeExporter commented 9 years ago 
Yes ok indeed. I was highly surprised by the deprecation of j2k_read_eoc but 
it's now taken care in opj_j2k_read_tile_header. I'm not convinced by this 
choice so it's a good idea to keep the "ifdef 0" for now.

Original comment by antonin on 4 Mar 2014 at 9:31

GoogleCodeExporter commented 9 years ago

Original comment by mathieu.malaterre on 14 Mar 2014 at 2:03

GoogleCodeExporter commented 9 years ago 
Ok, then marking as fixed.

Original comment by mathieu.malaterre on 17 Mar 2014 at 10:39