xinxinlx / openjpeg

Automatically exported from code.google.com/p/openjpeg
Other
0 stars 0 forks source link

Verify -help actually match letter #307

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Make sure that opj_compress and opj_decompress have proper help message box.

Original issue reported on code.google.com by mathieu.malaterre on 24 Mar 2014 at 2:54

GoogleCodeExporter commented 9 years ago
Check f/F/q

Original comment by mathieu.malaterre on 24 Mar 2014 at 2:55

GoogleCodeExporter commented 9 years ago
I do not see anything wrong with:

        case 'r':           /* rates rates/distorsion */
        {
            char *s = opj_optarg;
            parameters->tcp_numlayers = 0;
            while (sscanf(s, "%f", ¶meters->tcp_rates[parameters->tcp_numlayers]) == 1) {
                parameters->tcp_numlayers++;
                while (*s && *s != ',') {
                    s++;
                }
                if (!*s)
                    break;
                s++;
            }
            parameters->cp_disto_alloc = 1;
        }

vs:

        case 'q':           /* add fixed_quality */
        {
            char *s = opj_optarg;
            while (sscanf(s, "%f", ¶meters->tcp_distoratio[parameters->tcp_numlayers]) == 1) {
                parameters->tcp_numlayers++;
                while (*s && *s != ',') {
                    s++;
                }
                if (!*s)
                    break;
                s++;
            }
            parameters->cp_fixed_quality = 1;
        }

Original comment by mathieu.malaterre on 25 Mar 2014 at 9:57

GoogleCodeExporter commented 9 years ago
This was the mail that made me think that options were not correctly used : 
https://groups.google.com/d/msg/openjpeg/oPSoy-y0RoE/PJuUNZbauj8J

But it appears everything is fine.

An update from 15/01 shows that there is another issue : options -s and -q 
cannot be used together. Fixed this and create new issue.
http://ericportis.com/posts/2014/resolution-progressive-jpeg2000-performance/

Original comment by antonin on 25 Mar 2014 at 10:26