Need #ifdef for proper OpenJPEG API handling

xinxinlx / openjpeg

Automatically exported from code.google.com/p/openjpeg

Other

0 stars 0 forks source link

Need #ifdef for proper OpenJPEG API handling #342

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

OpenJPEG has been changing its API recently. Basically there are now three well 
known APIs:

- 1.x
- 2.x (2.0.x technically)
- 2.1 introduced some new functionalities, which conflicted with 2.0

Original issue reported on code.google.com by mathieu.malaterre on 28 Apr 2014 at 7:31

GoogleCodeExporter commented 9 years ago

This issue was closed by revision r2859.

Original comment by mathieu.malaterre on 28 Apr 2014 at 7:32

Changed state: Fixed

GoogleCodeExporter commented 9 years ago

Re-openning issue:

- Need to discuss whether to use OPENJPEG_* or OPJ_* for consistency
- This is bad to expose ABI information at API level (header file), may need to 
remove the *SOVERSION info.

Original comment by mathieu.malaterre on 28 Apr 2014 at 7:56

Changed state: Started

GoogleCodeExporter commented 9 years ago

Regarding naming convention: as OPJ is used everywhere in the API to prefix 
functions and data structures, I would suggest to use it also to prefix version 
number in opj_config.h.

Original comment by antonin on 28 Apr 2014 at 9:11

GoogleCodeExporter commented 9 years ago

This issue was closed by revision r2863.

Original comment by mathieu.malaterre on 28 Apr 2014 at 9:17

Changed state: Fixed